CFE-4665: cfengine dev format docs should tell you what files it formatted#144
Open
sarakthon wants to merge 1 commit into
Open
CFE-4665: cfengine dev format docs should tell you what files it formatted#144sarakthon wants to merge 1 commit into
cfengine dev format docs should tell you what files it formatted#144sarakthon wants to merge 1 commit into
Conversation
|
Thank you for submitting a PR! Maybe @larsewi can review this? |
larsewi
approved these changes
Jun 7, 2026
olehermanse
requested changes
Jun 8, 2026
sarakthon
force-pushed
the
print-formatted-files
branch
from
e258eec to
eabbd82
Compare
olehermanse
requested changes
Jun 11, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
As mentioned yesterday, let's try to make the formatting functions return the true/false value we need to know if something was reformatted or not.
Also, please make a comment / edit the first comment (PR description) to show it working (command and output in a code block). Show what you've been testing, and how it was before and after your changes.
sarakthon
force-pushed
the
print-formatted-files
branch
2 times, most recently
from
2ba2ceb to
a451365
Compare
…rmatted Ticket: CFE-4665
sarakthon
force-pushed
the
print-formatted-files
branch
from
a451365 to
fc9469f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4665
Made a
test.py,test.mdandtest2.mdthat needs reformatting:test.py:test.md:And
test2.mdwith wrongly formatted json.Command and output before changes:
Command and output after changes:
First run with unformatted files:
Second run:
Added a trailing newline in
fn_extractfor correct pretty_file diffing, else it would always return True even though the file wasn't reformatted.Also moved the
Formatting with {...}prints inside the actual formatting functions, so they only print if something is reformatted.